Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mirror node #1632

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Conversation

skoriop
Copy link
Contributor

@skoriop skoriop commented Feb 28, 2024

This will add the Mirror node:

  • Define a new node that just outputs the vector data that has been input (to ensure nodes are set up properly).
  • Compute the pivot position of the vector data using the appropriate function.
  • Clone the subpaths in the vector data and mirror all of the positions around the computed pivot.

This will close #1453 when finished.

@Keavon
Copy link
Member

Keavon commented Mar 3, 2024

Your code looks nice! However I need to get @TrueDoctor's comment about the addition of the pivot field, because this addition may likely conflict with his ongoing work to revamp the transform system. I'm not sure how to proceed with that so I'll wait for him to reply here.

@Keavon
Copy link
Member

Keavon commented Mar 11, 2024

Blocked on #1558. We'll have to let this wait a bit. Hopefully @TrueDoctor can complete that issue in the next week or two.

Because it'll require a little bit of rework once that is merged (sorry for the trouble!), and because I want to make sure I can know which PRs require my attention, I'm going to mark this as a draft PR for now to help me stay organized. Apologies for the delay and extra effort this blockage, which isn't your fault, will incur.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the Mirror node
2 participants