Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add grid color customization and choice to display as dots #1743

Merged
merged 11 commits into from
May 8, 2024
Merged

Conversation

adamgerhant
Copy link
Collaborator

@adamgerhant adamgerhant commented May 8, 2024

Closes #1704, closes #1703

Adds a dot type grid option to create a pixel aligned dot grid. Snapping and spacing is the same as the rectangular grid.

Changes:

  • Adds grid_overlay_dot
  • Adds overlay_context.pixel
  • UI changes for selecting the Dot option
  • Color selector UI

Note: blocked by #1710 since initial color is not correct.
Initial color starts at #999999 instead of #cccccc. An easy fix could be to replace the hex constant with a Color.

chrome_4ItMjh63Mi

@Keavon
Copy link
Member

Keavon commented May 8, 2024

Please add dotted isometric grid visualization and then we are good to merge.

Copy link
Member

@Keavon Keavon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work and awesome feature!

@Keavon Keavon enabled auto-merge (squash) May 8, 2024 21:30
@Keavon Keavon merged commit bc33eab into master May 8, 2024
2 checks passed
@Keavon Keavon deleted the dot-grid branch May 8, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grid as dots Customising grid colour
2 participants