Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support any precision in PromQL #3933

Merged
merged 2 commits into from
May 16, 2024
Merged

feat: support any precision in PromQL #3933

merged 2 commits into from
May 16, 2024

Conversation

Taylor-lagrange
Copy link
Contributor

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Support any precision in PromQL

Please explain IN DETAIL what the changes are in this PR and why they are needed:

When detect non-millisecond timestamp in PromQL planner on time index, cast it to ms.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@Taylor-lagrange Taylor-lagrange requested review from waynexia and a team as code owners May 14, 2024 06:38
@github-actions github-actions bot added the docs-required This change requires docs update. label May 14, 2024
@sunng87 sunng87 mentioned this pull request May 14, 2024
Open
evenyag
evenyag reviewed May 15, 2024
View reviewed changes
src/promql/src/extension_plan/instant_manipulate.rs Outdated Show resolved Hide resolved
src/promql/src/extension_plan/normalize.rs Outdated Show resolved Hide resolved
src/promql/src/extension_plan/range_manipulate.rs Outdated Show resolved Hide resolved
src/promql/src/planner.rs Outdated Show resolved Hide resolved
src/promql/src/planner.rs Show resolved Hide resolved
killme2008
killme2008 approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +:1

@codecov Codecov
Copy link

codecov bot commented May 16, 2024 •
edited

Codecov Report

Attention: Patch coverage is 91.46341% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 85.32%. Comparing base (60eb5de) to head (6ab7d7f).
Report is 23 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3933      +/-   ##
==========================================
- Coverage   85.98%   85.32%   -0.66%     
==========================================
  Files         963      972       +9     
  Lines      164532   166993    +2461     
==========================================
+ Hits       141474   142489    +1015     
- Misses      23058    24504    +1446

@evenyag evenyag added this pull request to the merge queue May 16, 2024
Merged via the queue into GreptimeTeam:main with commit 9f4a6c6 May 16, 2024
20 checks passed
@Taylor-lagrange Taylor-lagrange deleted the feat-promql-precision branch May 17, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killme2008 killme2008 killme2008 approved these changes

@evenyag evenyag evenyag approved these changes

@waynexia waynexia Awaiting requested review from waynexia waynexia is a code owner

Assignees
No one assigned
Labels
docs-required This change requires docs update.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Taylor-lagrange @killme2008 @evenyag