Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update hotkey.lua: add isActive #3608

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update hotkey.lua: add isActive #3608

wants to merge 1 commit into from

Conversation

muescha
Copy link
Contributor

@muescha muescha commented Feb 29, 2024

add isActive

See:

github-actions[bot]
github-actions bot requested changes Feb 29, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['pr-fix', 'pr-change', 'pr-feature', 'pr-maintenance']

@muescha
Copy link
Contributor Author

muescha commented Feb 29, 2024

TODO:

  • add docs if accepted
  • should it be better as function like htm:isActive()?

@muescha muescha mentioned this pull request Feb 29, 2024
Open
@github-actions GitHub Actions
Copy link

View Test Results

2 tests   2 ✔️  0s ⏱️
2 suites  0 💤
1 files    0 ❌

Results for commit d78aeef.

@muescha
Copy link
Contributor Author

muescha commented Feb 29, 2024

i can not see why the test are failing :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@muescha