Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

github_runner_matrix: add -x86_64 to Intel runner names #17222

Merged
merged 2 commits into from May 11, 2024
Merged

github_runner_matrix: add -x86_64 to Intel runner names #17222

merged 2 commits into from May 11, 2024

Conversation

carlocab
Copy link
Member

@carlocab carlocab commented May 3, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

See Homebrew/ci-orchestrator#15.

Needs Homebrew/ci-orchestrator#15.

MikeMcQuaid
MikeMcQuaid approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

@carlocab carlocab marked this pull request as ready for review May 11, 2024 18:06
@carlocab carlocab enabled auto-merge May 11, 2024 18:10
@carlocab carlocab merged commit 71c4bfa into master May 11, 2024
25 checks passed
@carlocab carlocab deleted the intel-runner-tag branch May 11, 2024 18:19
carlocab added a commit to Homebrew/actions that referenced this pull request May 11, 2024
@carlocab
pre-build: use more specific bottle glob
0a38483 
Follow up to:
- Homebrew/ci-orchestrator#15
- Homebrew/brew#17222
@carlocab carlocab mentioned this pull request May 11, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@carlocab @MikeMcQuaid