Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-cmd/tap-new: add Brewfile documentation to readme template #17256

Merged
merged 2 commits into from May 9, 2024

Conversation

jasonkarns
Copy link
Contributor

@jasonkarns jasonkarns commented May 8, 2024

It would be helpful for taps to document how they are to be used with Brewfile.

Adding documentation for formulae installation to the generated tap readme would help ensure that new taps have this helpful documentation in their repos from the start.

This is primarily a follow-up to Homebrew/homebrew-cask-fonts#9359 which itself was opened after I spent a significant amount of time trying to figure out how to get a font installed as part of my Brewfile.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

It would be helpful for taps to document how they are to be used with `Brewfile`.

Adding documentation for formulae installation to the generated tap readme would help ensure that new taps have this helpful documentation in their repos from the start.
@jasonkarns jasonkarns changed the title Add Brewfile documentation to tap-new readme template dev-cmd/tap-new: Add Brewfile documentation to readme template May 8, 2024
@jasonkarns jasonkarns changed the title dev-cmd/tap-new: Add Brewfile documentation to readme template dev-cmd/tap-new: add Brewfile documentation to readme template May 8, 2024
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this idea, thanks @jasonkarns.

@Homebrew/maintainers any objections?

Library/Homebrew/dev-cmd/tap-new.rb Outdated Show resolved Hide resolved
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
@jasonkarns
Copy link
Contributor Author

Good suggested changes @MikeMcQuaid . I'll update the cask-fonts tap PR to match.

@jasonkarns
Copy link
Contributor Author

Quick aside question: I haven't frequently made changes to brew itself (it's been a long while).

The PR template requests running brew style, brew typecheck and brew tests. But it's not clear if these are expected to work somehow within the context of a Homebrew/brew working copy, or if they only run against the "installed" version of homebrew. Does brew magically detect it's in a clone of brew itself and run against the current working copy? Or do I need to go to /usr/local/Homebrew | /opt/homebrew and check out my branch to run these commands?

(And is this already clarified somewhere that I should have noticed?)

@MikeMcQuaid MikeMcQuaid merged commit c1c4f45 into Homebrew:master May 9, 2024
25 checks passed
@MikeMcQuaid
Copy link
Member

if they only run against the "installed" version of homebrew.

This 👍🏻

Or do I need to go to /usr/local/Homebrew | /opt/homebrew and check out my branch to run these commands?

This 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants