Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mecab, mecab-ipadic: fix build on Sonoma #171139

Merged
merged 4 commits into from May 15, 2024
Merged

mecab, mecab-ipadic: fix build on Sonoma #171139

merged 4 commits into from May 15, 2024

Conversation

carlocab
Copy link
Member

@carlocab carlocab commented May 8, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

This should help prevent #171137.

@carlocab carlocab added CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-no-bottles Merge without publishing bottles labels May 8, 2024
@github-actions github-actions bot added the missing license Formula has a missing license which should be added label May 8, 2024
@cho-m
Copy link
Member

cho-m commented May 14, 2024

May be due to mecab incorrectly/incompletely built.

For example, mecab isn't linked to Xcode libiconv based on mecab-ipadic logs showing iconv_open is not supported.


Sonoma ARM64:

otool -L mecab/0.996/bin/mecab
mecab/0.996/bin/mecab:
	@@HOMEBREW_CELLAR@@/mecab/0.996/lib/libmecab.2.dylib (compatibility version 3.0.0, current version 3.0.0)
	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1336.0.0)
	/usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 1600.151.0)

Ventura ARM64:

otool -L mecab/0.996/bin/mecab
mecab/0.996/bin/mecab:
	@@HOMEBREW_CELLAR@@/mecab/0.996/lib/libmecab.2.dylib (compatibility version 3.0.0, current version 3.0.0)
	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1319.0.0)
	/usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 1300.32.0)
	/usr/lib/libiconv.2.dylib (compatibility version 7.0.0, current version 7.0.0)

@carlocab
Copy link
Member Author

Must've been built with a bad version of Xcode. Here's one local build on Sonoma:

❯ brew linkage mecab
System libraries:
  /usr/lib/libSystem.B.dylib
  /usr/lib/libc++.1.dylib
  /usr/lib/libiconv.2.dylib
Homebrew libraries:
  /opt/homebrew/Cellar/mecab/0.996/lib/libmecab.2.dylib (mecab)

@carlocab carlocab removed the CI-no-bottles Merge without publishing bottles label May 14, 2024
@carlocab carlocab changed the title mecab-ipadic: update test mecab, mecab-ipadic: fix build on Sonoma May 14, 2024
@carlocab carlocab added the ready to merge PR can be merged once CI is green label May 14, 2024
@carlocab
Copy link
Member Author

We need new bottles because the ones built for Sonoma are broken.

Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label May 15, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue May 15, 2024
Merged via the queue into master with commit 5d37f3d May 15, 2024
14 checks passed
@BrewTestBot BrewTestBot deleted the mecab-ipadic-test branch May 15, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. missing license Formula has a missing license which should be added ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants