Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add files via upload #1142

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add files via upload #1142

wants to merge 1 commit into from

Conversation

Maricruzhdz
Copy link

@Maricruzhdz Maricruzhdz commented Jan 11, 2022 •
edited

What?

Why?

How?

Testing?

New Dependencies?

Screenshots

Suggested Reading?

Anything Else?

Checklist

  • I read CONTRIBUTING.md.
  • I read MAINTAINERSHIP.md#pull-requests.
  • I added/updated unit tests for my changes.
  • I added/updated integration tests for my changes.
  • I ran the integration tests.
  • I tested my changes in Node, Deno, and the browser.
  • I viewed documents produced with my changes in Adobe Acrobat, Foxit Reader, Firefox, and Chrome.
  • I added/updated doc comments for any new/modified public APIs.
  • My changes work for both new and existing PDF files.
  • I ran the linter on my changes.

Maricruzhdz
Maricruzhdz commented Jan 11, 2022
View reviewed changes
Copy link
Author

@Maricruzhdz Maricruzhdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I lost my contacta

Maricruzhdz
Maricruzhdz commented Jan 16, 2022
View reviewed changes
Copy link
Author

@Maricruzhdz Maricruzhdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

Sharcoux
Sharcoux reviewed May 11, 2022
View reviewed changes
Copy link

@Sharcoux Sharcoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This MR should probably be closed, unless I'm missing something.

@asmblur
Copy link

asmblur commented Apr 5, 2023

Please close this MR as it's clearly not something that will get merged. Not even sure why @Maricruzhdz submitted it if they actually went through the checklist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sharcoux Sharcoux Sharcoux left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
needs-triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Maricruzhdz @asmblur @Sharcoux