update docs for running natively vs in Docker #113
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #113 +/- ##
==========================================
- Coverage 45.06% 44.16% -0.90%
==========================================
Files 39 40 +1
Lines 1782 1818 +36
==========================================
Hits 803 803
- Misses 979 1015 +36 ☔ View full report in Codecov by Sentry. |
| - KAFKA_CFG_CONTROLLER_LISTENER_NAMES=CONTROLLER | ||
| - KAFKA_CFG_LISTENERS=PLAINTEXT://:9093,CONTROLLER://:2181 | ||
| - KAFKA_CFG_LISTENER_SECURITY_PROTOCOL_MAP=CONTROLLER:PLAINTEXT,PLAINTEXT:PLAINTEXT | ||
| #- KAFKA_CFG_ADVERTISED_LISTENERS=PLAINTEXT://kafka:9093 |
There was a problem hiding this comment.
should probably remove this
There was a problem hiding this comment.
wanted to highlight that this value is different vs the other docker-compose file, will add a comment
There was a problem hiding this comment.
could we name this file something a bit more descriptive, maybe just docker-compose.develop.yml? I don't think this is quite "native" if it's running on docker compose.
There was a problem hiding this comment.
You can develop both ways, and the corresponding readme sections are titled "run natively" and "run in Docker" - this way, the app and workers are running natively and only the off-the-shelf redis and kafka are in docker. Is there a better name that suits this situation?
There was a problem hiding this comment.
gonna go ahead and merge this for now so as not to block the corresponding LSE change
No description provided.