add base url for openai client #84
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklub
requested changes
Apr 25, 2024
| return OpenAI(api_key=self.openai_api_key) | ||
| return OpenAI( | ||
| api_key=self.openai_api_key, | ||
| base_url=DEFAULT_CREATE_COMPLETION_URL |
There was a problem hiding this comment.
Does the base URL refer to the completion endpoint but not something like https://api.openai.com/v1 ?
|
Hi Niklub,
It refer to something like https://api.openai.com/v1/
Allow to change it future can make adala support models through apps like
litellm proxy.
Peter Ze TANG (汤赜)
…On Thu, Apr 25, 2024 at 6:25 PM niklub ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In adala/runtimes/_openai.py
<#84 (comment)>:
> @@ -167,7 +167,10 @@ class OpenAIChatRuntime(Runtime):
@computed_field
def _client(self) -> OpenAI:
- return OpenAI(api_key=self.openai_api_key)
+ return OpenAI(
+ api_key=self.openai_api_key,
+ base_url=DEFAULT_CREATE_COMPLETION_URL
Does the base URL refer to the completion endpoint but not something like
https://api.openai.com/v1 ?
—
Reply to this email directly, view it on GitHub
<#84 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAPJIZY5CS4QUF3EUBFZBVLY7DKYRAVCNFSM6AAAAABFXJK2ZSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAMRSGEZDCMRYGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add base url for openai client to support customer url in future