Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): support of include-imports in export command #1450

Merged

Conversation

Cristobal-M
Copy link

@Cristobal-M Cristobal-M commented Feb 23, 2024

Description 📣

This change will give support for imported secrets in infisical export command. With the same flag --include-imports as infisical run command already present in v0.16.10

This PR is for issue: #1015

EDIT: added in this PR #1663. But --include-imports flag still not documented, reset from main and commited changes in *.mdx.

Type ✨

  • Bug fix
  • New feature
  • Breaking change
  • Documentation

Tests 🛠️

  1. Create two folders folder-a and folder-b
  2. Create new secrets in folder-a
  3. Create import in folder-b with folder-a as target, and create some secrets
  4. This command should ouput folder-a and folder-b secrets
infisical export --path=/folder-b
  1. With the new flag to false it will give only folder-b secrets
infisical export --path=/folder-b --include-imports=false

@Cristobal-M
Copy link
Author

Added --include-imports documentation for export and run (is missing)

@akhilmhdh
Copy link
Member

Hey @Cristobal-M Can you kindly rebase the PR. We are happy to merge this.

Copy link

gitguardian bot commented May 16, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@Cristobal-M Cristobal-M force-pushed the feat-support-imports-in-cli-export branch from d048a4b to 57192b0 Compare May 16, 2024 09:22
@Cristobal-M
Copy link
Author

Cristobal-M commented May 16, 2024

Hi @akhilmhdh I can see this functionality has already been added in this PR #1663
But documentation was missing so I have reset from main leaving only changes in .mdx

@Cristobal-M Cristobal-M force-pushed the feat-support-imports-in-cli-export branch from 57192b0 to a6fe233 Compare May 16, 2024 09:44
@akhilmhdh akhilmhdh merged commit 1438415 into Infisical:main May 17, 2024
2 checks passed
@akhilmhdh
Copy link
Member

Thanks @Cristobal-M

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move secret referencing logic to Rest API [ENG-118] Imports are not supported in infisical export command
2 participants