COMP: Fix ununsed code ( if(false) ) #4674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type:Compiler
dzenanz
reviewed
May 16, 2024
There was a problem hiding this comment.
This pattern is used to be able to quickly change the code to test a feature.
The proper fix here would be to expose a new command-line parameter and use it in the if clause. Bonus points if that new command line parameter is exercised in corresponding test specification, e.g. https://github.com/InsightSoftwareConsortium/ITK/blob/v5.4rc03/Modules/Registration/Metricsv4/test/CMakeLists.txt#L113-L123.
andrei-sandor
force-pushed
the
WunreachableCode
branch
from
1a48219
to
85e46d2
Compare
|
For the last commit, we would like to know what better name would it be to replace foo. Here, foo represents the variable false. |
dzenanz
reviewed
May 29, 2024
...gistration/Metricsv4/test/itkJointHistogramMutualInformationImageToImageRegistrationTest.cxx
Outdated
Show resolved
Hide resolved
Modules/Registration/Metricsv4/test/itkMultiGradientImageToImageMetricv4RegistrationTest.cxx
Outdated
Show resolved
Hide resolved
Modules/Registration/Metricsv4/test/itkMultiGradientImageToImageMetricv4RegistrationTest.cxx
Outdated
Show resolved
Hide resolved
andrei-sandor
force-pushed
the
WunreachableCode
branch
from
85e46d2
to
ca85ce5
Compare
dzenanz
reviewed
May 29, 2024
| @@ -164,6 +164,10 @@ itkJointHistogramMutualInformationImageToImageRegistrationTest(int argc, char * | |||
| { | |||
| numberOfDisplacementIterations = std::stoi(argv[5]); | |||
| } | |||
| if (argc >= 7) | |||
There was a problem hiding this comment.
You need to declare the variables, e.g.
bool useScalesEstimator = true;
if (argc >= 7)
...This is a comment to fix the -Wunreachable-code warning generated by clang. This fix simply removes if (false) clauses. An investigation was done to see why these clause exist. This change was done 10 years ago. The clause at that time was if(0).
andrei-sandor
force-pushed
the
WunreachableCode
branch
from
ca85ce5
to
ba12c7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a comment to fix the -Wunreachable-code warning generated by clang.
This fix simply removes if (false) clauses. An investigation was done to see why these clause exist. This change was done 10 years ago. The clauses at that time were if(0).