COMP: remove suppression of -Winconsistent-missing-override #4682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type:Compiler
I tested with AppleClang 10, the oldest AppleClang submitting to cdash, and this false positive seems to have been fixed long ago.
seanm
force-pushed
the
unsuppress-old-warning
branch
from
c90d041
to
681294a
Compare
dzenanz
approved these changes
May 17, 2024
|
@dzenanz that "ITK.Linux.Python" bot seems to have failed pretty severely, any idea why? |
|
/azp run ITK.Linux.Python |
|
If a run fails, it is usually the most useful to look at the dashboard. Search for a build which contains the PR number in its name (in this case |
Good tip, I've noted in it my notes file. Seems it was a transient failure and is green now. (There seems to have a lot of these transient failures...) |
thewtex
approved these changes
May 29, 2024
|
@seanm thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested with AppleClang 10, the oldest AppleClang submitting to cdash, and this false positive seems to have been fixed long ago.