Fix D457 RGB sensor exposure control range issue #12251
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nir-Az
reviewed
Oct 3, 2023
| query.id = get_cid(option); | ||
| if (xioctl(_fd, VIDIOC_QUERYCTRL, &query) < 0) | ||
| if (xioctl(_fd, VIDIOC_QUERY_EXT_CTRL, &query) < 0) |
There was a problem hiding this comment.
Will this affect other controls as well?
Does this means this comment will be no longer relevant?
// Some controls (exposure, auto exposure, auto hue) do not seem to work on V4L2
// Instead of throwing an error, return an empty range. This will cause this control to be omitted on our UI sample.
// TODO: Figure out what can be done about these options and make this work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix d457 rgb sensor exposure ctrl range issue
changes:
change to VIDIOC_QUERY_EXT_CTRL instead of VIDIOC_QUERYCTRL when calling ioctls
Tracked on: RSDSO-19295