New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cardigann: fix search paths #14493
base: master
Are you sure you want to change the base?
cardigann: fix search paths #14493
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately this breaks YGG and Torlock when doing a search with no categories selected.
I think it's fine as is, it just requires slightly more upkeep when updating categories.
@ilike2burnthing take a look at the new commit :) |
Appreciate it, but I think the latest commits are more of a workaround, as we're then not using |
8ffea01
to
87a3fcb
Compare
87a3fcb
to
5ebe1de
Compare
Unfortunately this has the same drawbacks as before. You don't need to spend your time and energy on this, it's attempting to fix the tiniest of non-issues - saving us amending an additional line in a few definitions if their categories are ever updated. |
Haha, I'm more annoyed because I'm certain this should be the correct behavior. |
No description provided.