Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump to dotnet 8.0 #15083

Merged
merged 3 commits into from
Jun 2, 2024
Merged

Bump to dotnet 8.0 #15083

merged 3 commits into from
Jun 2, 2024

Conversation

mynameisbogdan
Copy link
Contributor

Description

Draft to test the builder with NET 8.0

8.0 needs a file migration for OSX to move ~/.config/Jackett to ~/Library/Application Support/Jackett.

Issues Fixed or Closed by this PR

@mynameisbogdan mynameisbogdan added the Don't Merge Hold up - don't merge this label Feb 25, 2024
@txtsd
Copy link

txtsd commented Mar 19, 2024

Thanks for doing this. I went at it a few weeks ago but I wasn't able to grok the automapper stuff.

@mynameisbogdan mynameisbogdan removed the Don't Merge Hold up - don't merge this label May 26, 2024
@mynameisbogdan mynameisbogdan marked this pull request as ready for review May 26, 2024 05:41
@ilike2burnthing
Copy link
Contributor

Can we bump PublishCodeCoverageResults to v2 here? Or is that better looked at separately (as I'm not sure it's even working)?

ilike2burnthing
ilike2burnthing reviewed May 26, 2024
View reviewed changes
Copy link
Contributor

@ilike2burnthing ilike2burnthing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still testing at the moment (Windows), but thus far all semi-private indexers are working fine; thrown in a mix of FlareSolverr and proxy usage as well. No slow down or high resource usage, even when running Test All.

@mynameisbogdan
Copy link
Contributor Author

Can we bump PublishCodeCoverageResults to v2 here? Or is that better looked at separately (as I'm not sure it's even working)?

I'll check later if it's working, but I'll rather avoid bumping it in the same PR.

@mynameisbogdan
Copy link
Contributor Author

@garfield69 @ilike2burnthing After #15357 is merged and rebased into this PR with a green light, I think this one is ready to be merged.

mynameisbogdan and others added 3 commits June 2, 2024 09:28
@garfield69 garfield69 merged commit 06ee63e into master Jun 2, 2024
25 checks passed
@garfield69 garfield69 deleted the net8 branch June 2, 2024 07:01
@garfield69
Copy link
Contributor

Excellent work, thank you @mynameisbogdan
does anyone think we need to give the linuxserver.io docker team a heads up that the next release will be on net8?

@mynameisbogdan
Copy link
Contributor Author

mynameisbogdan commented Jun 2, 2024 •
edited

I don't think there's the need, the build is self-contained thus it doesn't require a runtime to be installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilike2burnthing ilike2burnthing ilike2burnthing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mynameisbogdan @txtsd @ilike2burnthing @garfield69