Add border style extension to UIView #53
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrylmz
requested review from
JensK611,
smnbck,
rocklyve,
knothed,
fredpi,
jamitJona,
SimonNumberTwo and
jjorn
knothed
reviewed
Jul 8, 2021
| import Foundation | ||
| import UIKit | ||
|
|
||
| /// An enumeration to describe differnt types of `Radius`. |
There was a problem hiding this comment.
I think Radius would be better called BorderRadius: it is definitely tied to the specific use-case of view-borders because of the circular case, which doesn't make sense in a general setting. Radius seems to be a too general name here.
Optionally, and maybe more sensible, Radius could be a subtype of BorderStyle.
Then you could also change the doc comment to: An enumeration describing different kinds of border radii.
knothed
approved these changes
Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.