Version 1.18.4 - bugs corrections

Javinator9889 · Jun 9, 2018 · 2859125 · 2859125
1 parent 788860c
commit 2859125
Show file tree

Hide file tree

Showing 6 changed files with 39 additions and 17 deletions.
diff --git a/app/build.gradle b/app/build.gradle
@@ -8,8 +8,8 @@ android {
         applicationId "javinator9889.bitcoinpools"
         minSdkVersion 21
         targetSdkVersion 27
-        versionCode 70
-        versionName "1.18.3"
+        versionCode 71
+        versionName "1.18.4"
         testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"
     }
     buildTypes {

diff --git a/app/release/BitCoinPools-1.18.4.apk b/app/release/BitCoinPools-1.18.4.apk
diff --git a/app/release/output.json b/app/release/output.json
@@ -1 +1 @@
-[{"outputType":{"type":"APK"},"apkInfo":{"type":"MAIN","splits":[],"versionCode":70,"versionName":"1.18.3","enabled":true,"outputFile":"app-release.apk","fullName":"release","baseName":"release"},"path":"app-release.apk","properties":{}}]
+[{"outputType":{"type":"APK"},"apkInfo":{"type":"MAIN","splits":[],"versionCode":71,"versionName":"1.18.4","enabled":true,"outputFile":"app-release.apk","fullName":"release","baseName":"release"},"path":"app-release.apk","properties":{}}]
diff --git a/app/src/main/java/javinator9889/bitcoinpools/DataLoaderScreen.java b/app/src/main/java/javinator9889/bitcoinpools/DataLoaderScreen.java
@@ -51,20 +51,38 @@ protected void onCreate(@Nullable Bundle savedInstanceState) {
             Log.d(Constants.LOG.MATAG, Constants.LOG.CREATING_MAINVIEW);
             new DataLoader().execute();
         } else {
-            new MaterialDialog.Builder(this)
-                    .title(R.string.noConnectionTitle)
-                    .content(R.string.noConnectionDesc)
-                    .cancelable(false)
-                    .positiveText(R.string.accept)
-                    .onPositive(new MaterialDialog.SingleButtonCallback() {
-                        @Override
-                        public void onClick(@NonNull MaterialDialog dialog,
-                                            @NonNull DialogAction which) {
-                            onBackPressed();
-                        }
-                    })
-                    .build()
-                    .show();
+            try {
+                new MaterialDialog.Builder(this)
+                        .title(R.string.noConnectionTitle)
+                        .content(R.string.noConnectionDesc)
+                        .cancelable(false)
+                        .positiveText(R.string.accept)
+                        .onPositive(new MaterialDialog.SingleButtonCallback() {
+                            @Override
+                            public void onClick(@NonNull MaterialDialog dialog,
+                                                @NonNull DialogAction which) {
+                                onBackPressed();
+                            }
+                        })
+                        .build()
+                        .show();
+            } catch (Exception e) {
+                // MaterialDialog lib doesn't provide functionality to catch its own exception
+                // "DialogException" so we need to catch a global generally exception and cancel
+                // app execution. This happens because the application is trying to show a dialog
+                // after the app has been closed (there is no activity).
+                Log.e("MaterialDialog", "Not possible to show dialog - maybe the app is" +
+                        " closed. Full trace: " + e.getMessage());
+                try {
+                    this.finish();
+                } catch (Exception activityFinishException) {
+                    // Maybe closing the activity when execution failed throws an exception if
+                    // there is no possibility to close it
+                    Log.e("FinishException", "Impossible to finish the activity. Maybe " +
+                            "it is finished yet. More info: "
+                            + activityFinishException.getMessage());
+                }
+            }
         }
     }
 

diff --git a/app/src/main/res/values-es/strings.xml b/app/src/main/res/values-es/strings.xml
@@ -74,6 +74,8 @@
     <string name="github"><![CDATA[Accede al proyecto de GitHub justo aquí: <a href="https://github.com/Javinator9889/BitCoinPools">GitHub</a>]]></string>
     <string name="changelog">
         <![CDATA[
+        <h1>Versión 1.18.4 (09/06/18)</h1><i>
+        - Correcciones menores de bugs y fallos<br /></i>
         <h1>Versión 1.18.3 (28/04/18)</h1><i>
         - Corregidos errores menores en la aplicación<br />
         - Reducido el tamaño de la aplicación<br />

diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
@@ -97,6 +97,8 @@ SOFTWARE.<br />
     <string name="github"><![CDATA[Access to the GitHub project right here: <a href="https://github.com/Javinator9889/BitCoinPools">GitHub</a>]]></string>
     <string name="changelog">
         <![CDATA[
+        <h1>Version 1.18.4 (09/06/18)</h1><i>
+        - Minor bugs and issues corrections<br /></i>
         <h1>Version 1.18.3 (28/04/18)</h1><i>
         - Solved little errors in the app<br />
         - App size reduced<br />