Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small fix for skhd mode refresh from server #398

Merged
merged 1 commit into from
May 20, 2024

Conversation

nomppy
Copy link
Contributor

@nomppy nomppy commented May 2, 2024

Description

Tiny fix for skhd mode indicator

Fixes Jean-Tinland/simple-bar-server#3

How Has This Been Tested?

Mode refreshing now updates correctly

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

@Jean-Tinland
Copy link
Owner

Thanks for the fix! Wouldn't be better to trigger the refresh from the outside of simple-bar?

You could do the curl to simple-bar-server just after you triggered the mode change.

This way, the port wouldn't be hardcoded in simple-bar yabai-set-mode-server.sh script.

Please let me know if this would suits you! If so, I'll remove the curl present inside yabai-set-mode-server.sh.

@nomppy
Copy link
Contributor Author

nomppy commented May 20, 2024

I agree with you that it is better to trigger the refresh due tot he port. Initially I just copied the structure for the other set-mode.sh.

@Jean-Tinland Jean-Tinland merged commit 736f9af into Jean-Tinland:master May 20, 2024
@Jean-Tinland
Copy link
Owner

Ok, I merged your PR and removed the internal curl. You can now add the curl to your change mode trigger!

Thank you for your help :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

skhd mode indicator
2 participants