CPU Monitor Click Through #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding in the ability to click on this widget I wanted users to be able to use either 'top' or 'activity monitor'. Because 'top' is run in a terminal I wanted users to be able to specify their preferred Terminal. I added two terminal options Terminal and iTerm2. Hopefully the ability to open a terminal of the users choosing and run an arbitrary command will be helpful else where in the project.
|
This is really nice! I like the extensible system allowing to choose in which terminal to run any command. Thank you for your work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I was seeing spikes in CPU usage in simple bar, I was wondering what was causing the spikes and I found my self naturally clicking on the graph.
This lead me to add clicking on the widget to open a cpu monitor. I know people had different preferences about what should open so I made it configurable. Specifically I added 'top' and 'Activity Monitor' which both ship with macOS. I also added configurability to select which terminal 'top' runs in. I added two terminals "Terminal" and "iTerm2" I think this code has potentially to be useful in other parts of the project, but I cant for the life of me think of any good examples maybe people want to open "Spotify TUI" from simple bar given spotify behaves poorly with yabai?
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
There are the following possible options that have been tested:
Checklist:
Changes to make to the documentation
None