-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JAR manifest header folding #2755
base: master
Are you sure you want to change the base?
Conversation
How should I go about testing? It's a bit of mish-mash looking around at other files |
public String getPlaceholderText(@NotNull ASTNode node) { | ||
if (node.getPsi() instanceof Header) { | ||
String usefulText = node.getText().trim(); | ||
if (usefulText.length() <= MAX_BYTES_PER_LINE) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a useful proxy, the viewer cuts off placeholders that are too long with soft-wrapping (well you can still horizontally scroll).
In this case, adding more detail in the placeholder shouldn't add more cognitive load
|
||
@Override | ||
public boolean isCollapsedByDefault(@NotNull ASTNode node) { | ||
return false; // no change in existing behaviour |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can avoid this discussion for now. What the heuristic should be, should probably be discussed in an issue IMO
@sirgl Can I please get a review? |
Add folding support to make it easier to wrestle with large files. After this PR I'll add structure support though