Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OSGi headers to JAR manifest parser #2757

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mkem114
Copy link

@mkem114 mkem114 commented May 13, 2024

Makes the IDE squiglies more useful since common headers will be recognized

@jreznot jreznot assigned amaembo and unassigned jreznot May 15, 2024
@jreznot jreznot requested a review from amaembo May 15, 2024 20:35
@amaembo
Copy link
Contributor

amaembo commented May 16, 2024

I think similar functionality is provided by an OSGi plugin
https://plugins.jetbrains.com/plugin/1816-osgi
Here's the similar class:
https://github.com/JetBrains/intellij-plugins/blob/d4c63a37d1f3af1f15bb55406a58ecb61fade118/osmorc/src/org/osmorc/manifest/lang/header/OsgiManifestHeaderParsers.java

I don't feel that we need to duplicate it right in the IntelliJ Community.
Though probably we need to support more headers in OSGi plugin. Probably, the PR should update that class instead. @trespasserw please take a look, as I see that OSGi plugin was maintained by you.

@amaembo amaembo assigned trespasserw and unassigned amaembo May 16, 2024
@amaembo amaembo requested a review from trespasserw May 16, 2024 09:14
@mkem114
Copy link
Author

mkem114 commented May 21, 2024

I think similar functionality is provided by an OSGi plugin

Did the performance and bugginess problems with that plugin get resolved? Honestly seemed kinda dead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants