[K/N][CInterop] Add a contract to useContents
#5300
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isuckatcs
commented
May 13, 2024
isuckatcs
changed the title
contract to useContentscontract to useContents
isuckatcs
changed the title
contract to useContentscontract to useContents
^KT-66169 Fixed
KotlinBuild
pushed a commit
that referenced
this pull request
May 24, 2024
`kotlinx.cinterop.useContents` calls the passed block in-place and exactly once, but it lacked the corresponding contract. This affected certain use-cases, e.g. assigning to `val`s from the block in order to extract values of multiple fields. This commit fixes this by adding the `callsInPlace(block, InvocationKind.EXACTLY_ONCE)` contract to `useContents`. It also adds the same contract to `memScoped`, because `useContents` delegates to it, and thus it is required. ^KT-66169 Fixed
SvyatoslavScherbina
approved these changes
May 24, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
^KT-66169 Fixed