Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added: EAP support for PhpStorm #55

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mralaminahamed
Copy link

No description provided.

@@ -0,0 +1,5 @@
{
"code": "PS EAP",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the CI to work, this needs to be PS.

Additionally, since a EAP is not a release, we need to change a little bit in the core update mechanism. If you take a look into https://github.com/JonasGroeger/jetbrains-ppa/blob/master/update-packages#L57, you will see that we query only for type=release. You can try it yourself:

curl -s 'https://data.services.jetbrains.com/products/releases?code=PS&latest=true&type=release' | jq "."

To see EAP releases also, you need to change type=release to type=eap for this package only. I recommend either using a argument with release as default and optionally defined here in the package.json like eap:

curl -s 'https://data.services.jetbrains.com/products/releases?code=PS&latest=true&type=eap' | jq "."

Alternatively, we could also embed the full URL here into the package.json.

@JonasGroeger
Copy link
Owner

The .deb file contains some files that have a ~ at the end.

$ dpkg -x clion_2018.1.2_all.deb cl
$ dpkg -x phpstorm-eap_223.4884.75_all.deb ps
$ tree cl
cl
└── usr
    ├── bin
    │   └── clion
    └── share
        ├── applications
        │   └── clion.desktop
        ├── doc
        │   └── clion
        │       └── changelog.gz
        └── icons
            └── clion.png
7 directories, 4 files

$ tree ps
ps
├── package.json~
├── postinstall~
├── postremove~
├── preinstall~
└── usr
    ├── bin
    │   ├── phpstorm-eap
    │   └── phpstorm-eap~
    └── share
        ├── applications
        │   ├── phpstorm-eap.desktop
        │   └── phpstorm-eap.desktop~
        ├── doc
        │   └── phpstorm-eap
        │       └── changelog.gz
        └── icons
            └── phpstorm-eap.png
7 directories, 10 files

Not sure where those files come from.

@JonasGroeger
Copy link
Owner

You might want to check what was done in #67 and refactor this PR to match the new way to get EAP releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants