Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrading MLJFlow.jl to v0.4.2 #1118

Merged
merged 1 commit into from
May 20, 2024
Merged

Upgrading MLJFlow.jl to v0.4.2 #1118

merged 1 commit into from
May 20, 2024

Conversation

pebeto
Copy link
Member

@pebeto pebeto commented May 18, 2024 

- Moved baseuri to apiroot, allowing users to specify its own API route (improving compatibility with platforms)
- Removed healthcheck function due to lack of support. It is not working on every platform providing a mlflow instance
- Added a MLFLOW_TRACKING_URI check when running tests

Release page

@pebeto pebeto requested a review from ablaom May 18, 2024 18:57
@pebeto pebeto self-assigned this May 18, 2024
@pebeto pebeto force-pushed the upgrading_mljflow_to_v0.5.1 branch from af9a54d to aa0cf90 Compare May 18, 2024 19:03
@pebeto pebeto changed the title Upgrading MLJFlow.jl to v0.5.1 Upgrading MLJFlow.jl to v0.4.2 May 18, 2024
ablaom
ablaom reviewed May 19, 2024
View reviewed changes
Project.toml Show resolved Hide resolved
ablaom
ablaom approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@ablaom ablaom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, with understanding of the follow up JuliaAI/MLJFlow.jl#40

@ablaom ablaom merged commit b8d19dc into dev May 20, 2024
3 checks passed
@ablaom ablaom mentioned this pull request May 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ablaom ablaom ablaom approved these changes

Assignees

@pebeto pebeto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pebeto @ablaom