Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show: improve processed StackTrace check #54381

Merged
merged 1 commit into from May 13, 2024
Merged

Conversation

topolarity
Copy link
Member

@topolarity topolarity commented May 6, 2024

This change is necessary for widely-typed vectors of stack traces to work correctly:

Base.show_backtrace(stdout, convert(Vector{Any}, Base.stacktrace()))

which currently outputs a confusing error:

Stacktrace:
ERROR: MethodError: no method matching iterate(::Base.StackTraces.StackFrame)
...

This change is necessary for widely-typed vectors of stack traces to
work correctly:
```
Base.show_backtrace(stdout, convert(Vector{Any}, Base.stacktrace()))
```

which currently outputs a confusing error:
```
Stacktrace:
ERROR: MethodError: no method matching iterate(::Base.StackTraces.StackFrame)
...
```
@tecosaur tecosaur added domain:display and printing Aesthetics and correctness of printed representations of objects. domain:error messages Better, more actionable error messages labels May 9, 2024
@KristofferC KristofferC merged commit bbae417 into master May 13, 2024
10 checks passed
@KristofferC KristofferC deleted the ct/show-backtrace-any branch May 13, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:display and printing Aesthetics and correctness of printed representations of objects. domain:error messages Better, more actionable error messages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants