don't truncate Memory when turning it into a String #54438
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscardssmith
requested review from
vtjnash and
jakobnissen
and removed request for
vtjnash
jakobnissen
added a commit
to jakobnissen/julia
that referenced
this pull request
May 10, 2024
This commit builds upon JuliaLang#54438, re-using the old String(::Vector{UInt8}) impl, which now no longer truncates. Also remove takestring!(::Memory) - that function probably should not be defined
jakobnissen
approved these changes
May 10, 2024
jakobnissen
added a commit
to jakobnissen/julia
that referenced
this pull request
May 10, 2024
|
As we discussed, I've folded the changes in this PR into #54372 |
jakobnissen
added a commit
to jakobnissen/julia
that referenced
this pull request
May 10, 2024
This commit builds upon JuliaLang#54438, re-using the old String(::Vector{UInt8}) impl, which now no longer truncates. Also remove takestring!(::Memory) - that function probably should not be defined
jakobnissen
added a commit
to jakobnissen/julia
that referenced
this pull request
May 10, 2024
|
Probably needs some tests? |
jakobnissen
added a commit
to jakobnissen/julia
that referenced
this pull request
May 13, 2024
This commit builds upon JuliaLang#54438, re-using the old String(::Vector{UInt8}) impl, which now no longer truncates. Also remove takestring!(::Memory) - that function probably should not be defined
jakobnissen
added a commit
to jakobnissen/julia
that referenced
this pull request
May 13, 2024
|
I'm going to close this in favor of #54372 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was part of the triage decision on
String(::Memory)being unsound.