Linux: Set application ID properly

[guihkx]

This fixes window association issues on Linux.

Here's a before/after output from xprop:

Before:

$ xprop
...
_GTK_WINDOW_OBJECT_PATH(UTF8_STRING) = "/org/gtk/Application/anonymous/window/1"
_GTK_APPLICATION_OBJECT_PATH(UTF8_STRING) = "/org/gtk/Application/anonymous"

After:

$ xprop
...
_GTK_WINDOW_OBJECT_PATH(UTF8_STRING) = "/com/github/KRTirtho/Spotube/window/1"
_GTK_APPLICATION_OBJECT_PATH(UTF8_STRING) = "/com/github/KRTirtho/Spotube"
_GTK_APPLICATION_ID(UTF8_STRING) = "com.github.KRTirtho.Spotube"

[KRTirtho]

But com.github.krtirtho.spotube isn't the domain of the project it was only applied for Flathub as flathub doesn't accept domain .oss

[guihkx]

I see...

On one hand, if I use oss.krtirtho.spotube globally, then window association on the Flatpak package will likely remain broken, because the application id has to match the name of its .desktop file.

On the other hand, the .desktop file on deb and rpm packages you distribute, is simply called spotube, which might also cause issues.

So, for your Linux packages I'd recommend you use the same id used on Flathub, and then rename the .desktop file accordingly (and optionally the icon file as well).

[KRTirtho]

I get your point, but can we do this conditionally instead of using a CMake variable? We can detect the runtime environment (Flatpak or not) and set the id accordingly.

https://stackoverflow.com/questions/75274925/is-there-a-way-to-find-out-if-i-am-running-inside-a-flatpak-appimage-or-another

[guihkx]

I'm not sure I understand. The com.github.KRTirtho.Spotube id is only applied to Unix-like OSes (excluding macOS):

spotube/linux/CMakeLists.txt

Lines 5 to 9 in bf3c8a5

	if(UNIX AND NOT APPLE)
	set(APPLICATION_ID "com.github.KRTirtho.Spotube")
	else()
	set(APPLICATION_ID "oss.krtirtho.spotube")
	endif()

[guihkx]

I think I understand what you mean now: Do you want to only use the com.github.KRTirtho.Spotube for Flatpak, and use a different one for different Linux packaging formats?

If that's the case, please note that window association will still remain broken with these other packaging formats, unless you rename the spotube.desktop file to <app ID>.desktop as well.