New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(clustering/rpc): more strict parameter checking when generating a RPC error #12951
Open
chronolaw
wants to merge
5
commits into
master
Choose a base branch
from
style/clustering_rpc_small_clean
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core/clustering
cherry-pick kong-ee
schedule this PR for cherry-picking to kong/kong-ee
labels
Apr 28, 2024
ADD-SP
reviewed
Apr 28, 2024
ADD-SP
reviewed
Apr 28, 2024
chronolaw
force-pushed
the
style/clustering_rpc_small_clean
branch
from
April 28, 2024 02:52
e6cbce1
to
0526a2f
Compare
ADD-SP
reviewed
Apr 28, 2024
ADD-SP
reviewed
Apr 28, 2024
ADD-SP
reviewed
Apr 28, 2024
ADD-SP
previously approved these changes
Apr 28, 2024
bungle
changed the title
style(clustering/rpc): minor code style improvment
style(clustering/rpc): minor code style improvement
Apr 29, 2024
ADD-SP
changed the title
style(clustering/rpc): minor code style improvement
fix(clustering/rpc): more strict parameter checking when generating a RPC error
Apr 30, 2024
ADD-SP
dismissed
their stale review
April 30, 2024 03:11
With the past several changes, this PR became a fix, not style, needs more works.
Removed label |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
minor code style improvement.
KAG-4441
Checklist
changelog/unreleased/kong
orskip-changelog
label added on PR if changelog is unnecessary. README.mdIssue reference
Fix #[issue number]