fix(dns): ignore records with non-matching types when parsing answers #13002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
cherry-pick kong-ee
chobits
requested review from
liverpool8056,
dndx,
chronolaw and
Tieske
and removed request for
dndx
liverpool8056
approved these changes
May 9, 2024
chronolaw
reviewed
May 14, 2024
chronolaw
approved these changes
May 14, 2024
dndx
approved these changes
May 14, 2024
|
Successfully created cherry-pick PR for |
git-hulk
pushed a commit
to git-hulk/kong
that referenced
this pull request
May 14, 2024
… when parsing answers (Kong#13002) Fix KAG-4446, FTI-5834
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Originally, Kong dns client will store records with non-matching domain/type when parsing answers. For instance, if Kong queried a domain with A type, and received CNAME+A records, Kong would store the CNAME record in its cache. Consequently, this would lead to subsequent queries for CNAME records, which is unnecessary behavior for a DNS client.
This fix will remove records with non-matching types, such as CNAME records from the answers of an A query.
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
Fix KAG-4446, FTI-5834