Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MagicKeyboard: Added key to insert old password #1074

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

georgh-
Copy link

@georgh- georgh- commented Sep 4, 2021

Added a key to ease the process of changing a password, by retrieving the previous password from an entry's history.

There are many reasons wanting to change a password even when using a password manager, for example, for expired passwords, known breaches or changing to a safer password after migrating to KeePassDX.

It's not clear or intuitive how to change change a password when using the MagicKeyboard on websites that require entering your previous valid password. This change introduces a key to retrieve an entry's old password for a streamlined procedure:

  1. Generate and save a new password for an entry in the keepass main window
  2. Open the change password form of the target website/app
  3. When requested to enter the old password, use the "Previous Password" key from MagicKeyboard
  4. Enter the new password using the normal password key

This process is resilient to errors, if the process timeouts or the password is rejected, the old password is still stored in the database. If the new password is rejected, the user can change it on the main app, save it, delete the last history entry (with the rejected password) and repeat.

I am not sure whether adding an extra key is your preferred way for this. After all, this feature is not used so often and having an additional key should be justified. Maybe it would be better as an entry of the "custom fields" menu? I am not sure what you would prefer (or even if this is acceptable on your vision for the app), so I appreciate your feedback.

Added a key to ease the process of changing a password, by retrieving the
previous password from an entry's hisotry.

There are many reasons wanting to change a password even when using a password
manager, for example, for expired passwords, known breaches or changing to a
safer password after migrating to KeePassDX.

It's not clear or intuitive how to change change a password when using the
MagicKeyboard. This change introduces a key to retrieve an entry's old
password for a streamlined procedure:
 1. Generate and save a new password for an entry in the keepass DB
 2. Open the change password form of the target website/app
 3. When requested to enter the old password, use the "Previous Password" key
 4. Enter the new password using the normal password key

This process is resilient to errors, if the process timeouts or the password
is rejected, the old password is still stored in the database. If the new
password is rejected, the user can change it on the main app, save it, delete
the last history entry (with the rejected password) and repeat.
@J-Jamet
Copy link
Member

J-Jamet commented Sep 4, 2021

Thanks it's a good idea to change the password. I'll look into it but I'm afraid it will cause confusion for users.
It's an advanced function, so it should be a bit hidden but accessible if we know it. I'll think about it (maybe a long press on the password button will display a dialog box but maybe your solution is the best, I haven't compiled and tested it yet, I'll have to see in use)

@J-Jamet J-Jamet added this to In progress in 3.1.0 via automation Sep 7, 2021
@J-Jamet J-Jamet moved this from In progress to To do in 3.1.0 Sep 7, 2021
@J-Jamet J-Jamet removed this from To do in 3.1.0 Jan 18, 2022
@J-Jamet J-Jamet added this to In progress in 3.2.0 via automation Jan 18, 2022
@J-Jamet J-Jamet moved this from In progress to To do in 3.2.0 Jan 18, 2022
@J-Jamet
Copy link
Member

J-Jamet commented Jan 27, 2022

OK, I've thought about the functionality and I think it's best to make a history selection of the entry from the Magikeyboard. With this process, all the input data in the keyboard will be loaded with the history data (not only the password).
I propose to make a drop-down list in a (history) button next to the input name. Clicking on one of the items will replace the data in the Magikeyboard.

@J-Jamet J-Jamet removed this from To do in 3.2.0 Jan 27, 2022
@J-Jamet J-Jamet added this to In progress in 3.4.0 via automation Feb 16, 2022
@J-Jamet J-Jamet moved this from In progress to To do in 3.4.0 Feb 18, 2022
@J-Jamet J-Jamet added this to the Magikeyboard milestone Mar 26, 2022
@J-Jamet J-Jamet moved this from To do to In progress in 3.4.0 Apr 8, 2022
@J-Jamet J-Jamet removed this from In progress in 3.4.0 Apr 8, 2022
@J-Jamet J-Jamet added this to In Progress in To study via automation Apr 8, 2022
@J-Jamet J-Jamet moved this from In Progress to To Do in To study Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
To study
  
To Do
Development

Successfully merging this pull request may close these issues.

None yet

2 participants