Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tags list feature #1551

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from

Conversation

kon3gor
Copy link

@kon3gor kon3gor commented Apr 4, 2023

Added tags list feature to nodes list as requested in #1539.

Preview

Screenshot 2023-04-04 at 20 24 57

Screenshot 2023-04-04 at 20 25 05

Screen.Recording.2023-04-04.at.20.24.02.mov

@J-Jamet
Copy link
Member

J-Jamet commented Apr 4, 2023

Pretty cool :)

@kon3gor
Copy link
Author

kon3gor commented Apr 24, 2023

@J-Jamet Hi, haven't you watched this yet?

@J-Jamet
Copy link
Member

J-Jamet commented Apr 24, 2023

Not yet, I have a lot of work at the moment, I put your MR for version 4.1.0, I have to manage the separation in module for version 4.0.0. I know it's long, sorry, but it will be processed, don't worry, thanks a lot for your work.

@kon3gor kon3gor force-pushed the feature/tags_in_nodes_list branch from 65f9966 to 5ee264b Compare May 28, 2023 06:23
AnimatorSet().apply {
play(slideAnimator)
interpolator = AccelerateDecelerateInterpolator()
addListener(object: Animator.AnimatorListener {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No StubAnimatorListener?

@J-Jamet
Copy link
Member

J-Jamet commented Jul 24, 2023

I've just done an initial check with a merge to resolve conflicts with the new features in develop version 4.0.0. : https://github.com/Kunzisoft/KeePassDX/tree/kon3gor-feature/tags_in_nodes_list

I think I'll do a simpler implementation than yours, i.e. make the tags scroll horizontally, so there's no need to expand and it'll be easier to use.
For the moment it's only for entries, I'm going to make it compatible with groups too.

You're coding well, but I'm going to simplify. Thanks for your work, I'm starting from your branch, as I'm going to make some big changes your code will be in any case in the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

None yet

2 participants