-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to conform to Material Design's style guide #4209
base: 14-dev
Are you sure you want to change the base?
Conversation
Hey there, Regarding Title Case, this was once implemented by two of our former team members due to its “visual prominence” and “a more symmetrical appearance”. It is also implemented with inspiration from Apple’s UX style guide, and so that’s why it stuck here. If we were to change this, I’d first ask the team internally regarding their stance on this change. Afterwards, I'll update you regarding this. (Personally, I also like Title Case for the labels/headings. I prefer sentence cade for the rest of the UI though.) Otherwise, the PR looks good. It seems like I forgot to update some other descriptions to match M3 guidelines, so thanks for the catch. |
Thanks for the comment. Do let me know of your decision. I missed the following changes:
While we're at it, could you add me as a proofreader for Serbian (Cyrillic) and Serbian (Latin) on Crowdin? I've been active there for a long time, and I am willing to maintain the translations. Also, there are some approved strings that need to be modified. My username is Rancher. Thanks. |
For the latter, sure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After discussion with the team, it seems like they’re fine with the changes. However, regarding the three (3) strings above, I’d recommend keeping the original text for clarity. (As of now, haven’t gotten around to make all the strings more consistent with their name
attribute)
Also regarding Proofreader
permissions in Crowdin, I’ve added you there.
Sorry for misusing this thread, but could you also add Bosnian and Croatian to Crowdin? I can work on them too (they are all part of the macrolanguage known as Serbo-Croatian). Also, what's the status of this PR? |
I've added those languages to Crowdin. Also thanks for reminding me of this PR; I'll just apply some changes tommorow and merge it. |
Description
I updated the strings.xml file to conform to Material Design's style guide. Here's what's changed:
The first change is probably the most controversial one, but I would like to know your stance on this. Personally, sentence case looks much better and more natural to me on mobile devices. See the diff for full changes.
Type of change
✅ General change (non-breaking change that doesn't fit the below categories like copyediting)
❌ Bug fix (non-breaking change which fixes an issue)
❌ New feature (non-breaking change which adds functionality)
❌ Breaking change (fix or feature that would cause existing functionality to not work as expected)