Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling private messages. Fixes #3640 #4094

Closed
wants to merge 2 commits into from

Conversation

dessalines
Copy link
Member

This adds a local user setting: enable_private_messages default true.

It then checks when sending to a local user, that both you and the recipient have that setting enabled.

It also checks on an apub private message receive, that you have it enabled, before creating it.

@Nutomic
Copy link
Member

Nutomic commented Oct 25, 2023

This is not enough, you also need to federate the setting as part of Person. That way pm buttons can properly be disabled for remote users too. I didnt find any existing property for this purpose, so you can simply call it enable_private_messages and add it to the context.

@dessalines dessalines marked this pull request as draft October 25, 2023 21:00
@richardARPANET
Copy link

This is greatly needed 👍 Can there also be a global setting?

@dessalines
Copy link
Member Author

dessalines commented Jan 22, 2024

Global setting should probably be in a different PR / issue. This is specifically to prevent harassment on a user-level.

@Nutomic
Copy link
Member

Nutomic commented May 17, 2024

Outdated, feel free to reopen when you work on it again.

@Nutomic Nutomic closed this May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants