Removing post url doesnt federate (ref #4372) #4378
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Post url should be removed by setting it to
Some(None)
on PostUpdateForm. But for federation we use PostInsertForm as there is no way to distinguish between insert and update. The insert form doesnt allow settingSome(None)
, onlySome(url)
orNone
. So there is currently no way to set the url to null. Not sure whats the best way to fix this. The same problem might affect other fields as well.