Adding a default_comment_sort_type column for local_site and local_user. #4469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Renamed SortType to PostSortType in the DB and code. - Renamed references to default_sort_type to default_post_sort_type. - Fixes #4128
dessalines
commented
Feb 24, 2024
| @@ -90,8 +90,14 @@ pub struct SaveUserSettings { | |||
| pub show_scores: Option<bool>, | |||
| /// Your user's theme. | |||
| pub theme: Option<String>, | |||
| pub default_sort_type: Option<SortType>, | |||
| /// The default post listing type, usually "local" | |||
There was a problem hiding this comment.
Grouped these together.
| @@ -166,7 +171,7 @@ pub struct GetPersonDetails { | |||
| pub person_id: Option<PersonId>, | |||
| /// Example: dessalines , or dessalines@xyz.tld | |||
| pub username: Option<String>, | |||
| pub sort: Option<SortType>, | |||
| pub sort: Option<PostSortType>, | |||
There was a problem hiding this comment.
Still debating whether to separate this into post_sort and comment_sort, or to keep the current post_sort_to_comment_sort mapping.
The combined view is still limited by #2444
There was a problem hiding this comment.
The mapping is necessary anyway because of search. Its pretty awkward but I dont see any good way to get rid of it.
|
|
||
| /// Returns a default instance-level comment sort type, if none is given by the user. | ||
| /// Order is type, local user default, then site default. | ||
| fn comment_sort_type_with_default( |
There was a problem hiding this comment.
Added an identical function to the one above, but for comment sort types.
There was a problem hiding this comment.
I tested these migrations, and they work well.
4 tasks
Nutomic
approved these changes
Feb 26, 2024
|
Sounds good. In that case I'll try to get on all the UI changes necessary for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
default_sort_type->default_post_sort_type