288 http error #309
Open
288 http error #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the previous "error" warning had a top margin the you may need to adjust your network warning was not fully stretched
ShowBlurb --> showBlurb
✅ Deploy Preview for lodestone-dashboard ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for lodestone-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Ynng
requested changes
Jul 20, 2023
verify if nullable is correctly implemented
- renamed sethttpProtocol --> setHttpProtocol - shortened if statement - moved classname directly into warningalert
CheatCod
approved these changes
Jul 29, 2023
Ynng
requested changes
Jul 30, 2023
| @@ -44,6 +45,7 @@ const CoreConnect = () => { | |||
| values: CoreConnectionInfo, | |||
| actions: FormikHelpers<CoreConnectionInfo> | |||
| ) => { | |||
| setHttpProtocol(values.protocol == "http"); | |||
There was a problem hiding this comment.
need to add a special case for localhost/127.0.0.1/etc, which does not need mixed content enabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed bug where http error popup shows up if user selects https
Type of change
Note: make sure your files are formatted with rust-analyzer