feat: display changelog on :LvimUpdate #3270
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylo252
reviewed
Oct 19, 2022
| @@ -68,14 +69,15 @@ function M.run_post_update() | |||
| M.reset_cache() | |||
|
|
|||
| Log:debug "Syncing core plugins" | |||
| require("lvim.plugin-loader").sync_core_plugins() | |||
| require("lvim.plugin-loader").sync_core_plugins(function() | |||
There was a problem hiding this comment.
this is the wrong function, you're probably thinking of update_base_lvim()
There was a problem hiding this comment.
no I put it there on purpose, because putting make_changelog in update_base_lvim() or in line 81, displays the window before packer's window and when packer window kicks in it overlaps with changelog window, so showing it after packer is done makes more sense
|
|
||
| if not in_headless then | ||
| vim.schedule(function() | ||
| if package.loaded["nvim-treesitter"] then | ||
| vim.cmd [[ TSUpdateSync ]] | ||
| end | ||
| -- TODO: add a changelog | ||
| vim.notify("Update complete", vim.log.levels.INFO) |
There was a problem hiding this comment.
Suggested change
| vim.notify("Update complete", vim.log.levels.INFO) | |
| Info.make_changelog() | |
| vim.notify("Update complete", vim.log.levels.INFO) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of #3218
Everytime I run
:LvimUpdateI have to go to github and check the commits log on LunarVim repo, so I thought it would be nice if lvim displays them after running:LvimUpdate, the PR still WIP, waiting for your thoughts on this