Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stability issues #487

Merged
merged 9 commits into from
May 23, 2024

Conversation

houkhouk
Copy link

@houkhouk houkhouk commented May 15, 2024

By submiting this PR, you agree with the associated license MIT) and with our Contributor License Agreement (CLA).

Before to begin

Thank you for contributing to the Luos project!

Before to begin, please follow these steps:

  • Ensure that this PR is not a duplicate.

Feel free to read the Luos contribution's guidelines and the documentation page to have more insight about how to contribute to Luos.

PR Description section

Description and dependencies

Please include here a summary of the changes and the related issue. List any dependencies that are required for this change.

Changes

Please choose the relevant options:

  • Bug fix (non-breaking change which fixes an issue)

Related issue(s)

Provide a list of the related issues that will be fixed by this PR.

  • Improve configuration robustness (avoid locking phys, manage unexpected UART interrupt)
  • Fix ROBUS timeout management
  • Fix routing table filtering

WARNING: Do not edit the checklist below.


Developer section

  • [Documentation] is up to date with new feature
  • [Tests] are passed OK (non regression, new features & bug fixes)
  • [Code Quality] please check if:
    • Each function has a header (description, inputs, outputs)
    • Code is commented (particularly in hard to understand areas)
    • There are no new warnings that can be corrected
    • Commits policy is respected (constitancy commits, clear commits comments)

QA section

  • [Review] tests for new features have been reviewed
  • [Changelog] is up-to-date with expected tags
    🆕 Feature: [Feature] Description...
    🆕 Added: [Feature] Description...
    🆕 Changed: [Feature] Description...
    🛠️ Fix: [Feature] Description...

@nicolas-rabault nicolas-rabault self-requested a review May 16, 2024 08:23
@houkhouk
Copy link
Author

I have pushed a new version of the timeout management algorithm. Tell me what you think about it.

@houkhouk houkhouk changed the title Fixes stability issues Fix stability issues May 22, 2024
@nicolas-rabault nicolas-rabault requested review from nicolas-rabault and removed request for nicolas-rabault May 22, 2024 12:25
@nicolas-rabault nicolas-rabault requested review from nicolas-rabault and removed request for nicolas-rabault May 23, 2024 10:14
@nicolas-rabault nicolas-rabault requested review from nicolas-rabault and removed request for nicolas-rabault May 23, 2024 13:17
@nicolas-rabault nicolas-rabault linked an issue May 23, 2024 that may be closed by this pull request
Copy link
Member

@nicolas-rabault nicolas-rabault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

network/robus_network/HAL/STM32G4/robus_hal.c Outdated Show resolved Hide resolved
@nicolas-rabault nicolas-rabault merged commit 6d2109d into Luos-io:rc_3.1.0 May 23, 2024
47 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] robus infinite collision condition still exist
2 participants