Add Pre-configured Avatars #753
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
madison-boman
commented
Apr 29, 2021
•
madison-boman
commented
- Creates Pre-configured Avatars via bundles to improve Avatar accessibility.
- Management is located in MissionControl > AvatarBundles > Pre-configured Avatars.
- Avatars can be set using only a keyboard and, supports screen readers.
- A user's avatar now has alternative text that describes the avatars outfit.
- Other Avatar interface accessibility improvements
added 27 commits
April 29, 2021 11:56
Only body layers can be edited and premade bundles
When a bundle is selected, resets the clothing on avatar container
Adds avatar or, throws error with saved state
fix build
Has new Annotations
Preserves the aria-label on the avatar container
These somehow got deleted during rebase
Added extra if statement that was deleted
After you click save with a premade avatar
iafb
suggested changes
Dec 21, 2021
There was a problem hiding this comment.
- Mission Control avatars bundle page should highlight the Default tab if no search is selected
- The default tab should only show default bundles and not pre-configured bundles
- Unlockable bundles that are part of a pre-configured avatar shouldn't be able to be deleted
- Items that are a part of any bundle shouldn't be able to be deleted
- When a user is loading the avatar page for the first time pre-configured avatars are being given as a default option for the user instead of just default bundles.
| { | ||
| var siteId = GetCurrentSiteId(); | ||
| var layers = await GetLayersAsync(); | ||
| var layerGroupings = layers |
There was a problem hiding this comment.
It looks like layer groupings aren't used, I think this can be flattened to just a List of AvatarLayers?
There was a problem hiding this comment.
Resolved in commit 5f2b703
| if (item != null) | ||
| { | ||
| var fileName = "item"; | ||
| var element = |
There was a problem hiding this comment.
A check can be done on the layer if it has ShowColorSelector set to true to see if a color needs to be added.
There was a problem hiding this comment.
Resolved in commit 91763bd
| </div> | ||
| <div class="col-xs-12 col-sm-7"> | ||
| <div class="row"> | ||
| <div class="col-xs-12 text-center hide" id="layer-container"> |
There was a problem hiding this comment.
This container is always hidden, is it needed?
There was a problem hiding this comment.
This is how the avatar layers are being updated with. Its the same approach as the public avatar page
…m/MCLD/greatreadingadventure into feature/add-preconfigured-avatars
@iafb:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.