Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to laravel 10 and running again #103

Open
wants to merge 16 commits into
base: next
Choose a base branch
from

Conversation

Letsplaybar
Copy link

@Letsplaybar Letsplaybar commented Sep 22, 2022

I upgraded the next branch to laravel 9,
updated all node modules so that no more vulnerabilities are displayed,
adjusted the changes that brought the version in
and changed from Puphpeteer to Browsershoot, since Puphpeteer is not Laravel 9 compatible.

Besides, I have everywhere adjusted the namespace at the models imports.

Last but not least I added a Dockerfile with which you can build a fully functional image,
with which I tested the platform several times.
After starting the image you only have to link the storage and execute the install/upgrade command.
In the container you have to mount the .env file and the storage folder.

@Letsplaybar
Copy link
Author

solves Issue #99

@MarceauKa
Copy link
Owner

What a good work! Let me some time to review that correctly :)

@Letsplaybar
Copy link
Author

how does it look, have you already taken a closer look at it in the meantime?

I'm just thinking if it would be useful to extend the link parsing that Twitter links are automatically parsed and the text + the images / videos are then displayed in the text field, or generally adjust the links so if an image is set (SEO) that this is also displayed and not only the text.

@Letsplaybar Letsplaybar changed the title Upgrade to laravel 9 and running again Upgrade to laravel 10 and running again Dec 17, 2023
@Letsplaybar
Copy link
Author

I have now upgraded the dependencies in the docker file and upgraded the project to Laravel 10 in my branch, since Laravel 9 will reach EOL in February. My Shaark instance is now running over the image I built over my branch and I haven't noticed any problems so far, both pdf and yt-dlp video archiving works. with the pdf you should only pay attention to the zombie processes that chromium currently generates, maybe a process manager should be included.

@Letsplaybar
Copy link
Author

I was kind and attached my Kubernetes configuration as a helm chart of how I have it running at my setup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants