Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃毟 Add Input Shaping with I2S_STEPPER_STREAM warning #27051

Conversation

thisiskeithb
Copy link
Member

@thisiskeithb thisiskeithb commented May 3, 2024

Description

As the title states, add an Input Shaping with I2S_STEPPER_STREAM warning for ESP32-based motherboards like the MKS TinyBee.

The warning is a bit inaccurate since it's a known issue that these are incompatible (and it just came up again on Discord), but I wanted to match the existing FT_MOTION + I2S_STEPPER_STREAM warning:

/**
* Fixed-Time Motion
*/
#if ALL(FT_MOTION, I2S_STEPPER_STREAM)
#warning "FT_MOTION has not been tested with I2S_STEPPER_STREAM."
#endif

I originally tried to sanity check this in #25632, but the PR got hijacked and turned into something else, so it was closed.

Requirements

Any ESP32 motherboard like the MKS TinyBee with I2S_STEPPER_STREAM and HAS_ZV_SHAPING (INPUT_SHAPING_X / INPUT_SHAPING_Y)

Benefits

Warn users that these settings may be incompatible (but we know they're not).

Configurations

Any ESP32 motherboard like the MKS TinyBee with I2S_STEPPER_STREAM and HAS_ZV_SHAPING (INPUT_SHAPING_X / INPUT_SHAPING_Y)

Related Issues

@thinkyhead thinkyhead merged commit e8d9532 into MarlinFirmware:bugfix-2.1.x May 20, 2024
62 checks passed
@thisiskeithb thisiskeithb deleted the pr/add_IS_with_I2S_STEPPER_STREAM_warning branch May 20, 2024 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants