Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get rid of unsafe code for float rounding #27121

Merged
merged 1 commit into from
May 22, 2024
Merged

get rid of unsafe code for float rounding #27121

merged 1 commit into from
May 22, 2024

Conversation

umanwizard
Copy link
Contributor

this exists now since 1.77 @sploiselle

@umanwizard umanwizard requested a review from a team as a code owner May 16, 2024 13:47
sploiselle
sploiselle approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@sploiselle sploiselle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, ty @umanwizard

@teskje teskje merged commit f5451e1 into MaterializeInc:main May 22, 2024
73 checks passed
@teskje
Copy link
Contributor

teskje commented May 22, 2024

Thanks you!

@materialize-bot materialize-bot mentioned this pull request May 23, 2024
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teskje teskje teskje approved these changes

@sploiselle sploiselle sploiselle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@umanwizard @teskje @sploiselle