Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output consistency: add list type #27125

Conversation

nrainer-materialize
Copy link
Contributor

@nrainer-materialize nrainer-materialize commented May 16, 2024

Prerequisites

This is based on:

Commits

1b33e4d output consistency: list type: add type and return spec
47d6757 output consistency: list type: add operation params
16a9019 output consistency: list type: add list values
d3659a7 output consistency: list type: add operations

Nightly

@nrainer-materialize nrainer-materialize marked this pull request as ready for review May 17, 2024 10:08
@ggevay
Copy link
Contributor

ggevay commented May 17, 2024

Should output consistency be run before merging this?

@nrainer-materialize
Copy link
Contributor Author

Should output consistency be run before merging this?

I had triggered a run (see the PR description), but it is not shown in the checks list because I rebased afterwards. Anyway, it is randomized testing, therefore it definitively does not hurt to do a further run: https://buildkite.com/materialize/nightly/builds/7825

@nrainer-materialize nrainer-materialize merged commit 8ced2d3 into MaterializeInc:main May 21, 2024
13 checks passed
@nrainer-materialize nrainer-materialize deleted the output-consistency/add-list-type branch May 21, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-testing Theme: tests or test infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants