Consolidate on references instead of owned data #27157
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation converts a
TupleRef
iterator into a vector and consolidates that. This might cause extra work if the data consolidates well because it needs to convert the whole input into owned data.With this change, we first collect the references into a vector, consolidate this, and then convert into an owned allocation.
I didn't measure the performance impact, but I saw this as a source of memory allocations in https://pprof.me/c3516597e535d8c64a2184c143c408db
Checklist
$T ⇔ Proto$T
mapping (possibly in a backwards-incompatible way), then it is tagged with aT-proto
label.