Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage/copy-to-s3: Require format option #27158

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rjobanp
Copy link
Contributor

@rjobanp rjobanp commented May 17, 2024

Motivation

Tips for reviewer

This leaves the default as TEXT for all other COPY statements, but requires the FORMAT option is provided for the copy-to-expr statement.

Checklist

@rjobanp rjobanp requested a review from a team May 17, 2024 18:16
@rjobanp rjobanp requested a review from a team as a code owner May 17, 2024 18:16
@rjobanp rjobanp requested a review from maddyblue May 17, 2024 18:16
Copy link
Contributor

@maddyblue maddyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm not sure how I feel about this from a SQL perspective because it differs from the postgres default. Maybe instead of defaulting to CSV for that variant, require that it be set to something (i.e., no default)? SQL council should weigh in.

@morsapaes
Copy link
Contributor

+1 making it a required option when the AWS CONNECTION option is specified.

@benesch
Copy link
Member

benesch commented May 18, 2024

+1 making it a required option when the AWS CONNECTION option is specified.

+1 from me too.

@rjobanp rjobanp force-pushed the copy-to-s3-format-default branch from d690d88 to 74f0750 Compare May 30, 2024 14:05
@rjobanp rjobanp force-pushed the copy-to-s3-format-default branch from 74f0750 to d34db04 Compare May 30, 2024 14:40
@rjobanp rjobanp changed the title storage/copy-to-s3: Set default format to CSV storage/copy-to-s3: Require format option May 30, 2024
@rjobanp
Copy link
Contributor Author

rjobanp commented May 30, 2024

Updated to make required instead of defaulted for COPY TO <expr>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

storage/s3: FORMAT option should be required or default to supported value
4 participants