Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Melhor visualização do progresso de mensagens enviadas #6

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Melhor visualização do progresso de mensagens enviadas #6

wants to merge 1 commit into from

Conversation

djonibourscheid
Copy link

  • Variável i mudada para index
  • Add variável totalMessages
  • Stauts das mensagens já enviadas no console

@djonibourscheid
mensagem do console.log melhorado
dfb610c 
- Variável 'i' mudada para 'index'
- Add variável 'totalMessages'
- Stauts das mensagens já enviadas no console
tiagomelojuca
tiagomelojuca approved these changes Jun 10, 2021
View reviewed changes
Copy link

@tiagomelojuca tiagomelojuca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Não acho que a utilização do símbolo i fira de alguma forma o Clean Code (nesse caso, claro, pelo escopo pequeno). Mas a feature de ver o progresso realmente ajuda... sempre que eu usava, ficava ansioso olhando pra tela até terminar tudo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiagomelojuca tiagomelojuca tiagomelojuca approved these changes

@SamuelvLopes SamuelvLopes SamuelvLopes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@djonibourscheid @tiagomelojuca @SamuelvLopes