JSBreakpointModule: add document.readyState checks #5495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
David-Moreira
requested changes
May 5, 2024
| } | ||
| else { | ||
| //The browser does not support Javascript event binding | ||
| if (document.readyState === 'interactive' || document.readyState === 'complete') { |
There was a problem hiding this comment.
I remember using the event DOMContentLoaded for doing stuff when the Dom is available. Is that no better? Since it seems like you are not guaranting that this code attaches the events in case the js is loaded and the document is not on those states? Am I wrong?
There was a problem hiding this comment.
The JS module deferred loaded, so we cannot listen for DOMContentLoaded.
There was a problem hiding this comment.
Sorry I don't follow. Do you mean, that tipically it will execute after the DOMContentLoaded has already been called?
How do you guarantee if the following condition is not true (document.readyState === 'interactive' || document.readyState === 'complete') that the events will be registered?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5482