Make private ip the same as geoip:private #1061
Open
+41
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently ip.IsPrivate and netip.Addr.IsPrivate only matches a part of private IPs.
|
https://datatracker.ietf.org/doc/html/rfc1918#section-3 These IPs are not clearly defined |
|
These are private IPs in https://github.com/MetaCubeX/meta-rules-dat/blob/meta/geo/geoip/private.list |
wwqgtxx
force-pushed
the
Alpha
branch
4 times, most recently
from
6321cfb
to
092e535
Compare
|
其实geoip:private里面的地址不应该叫做Private IP Addresses，而应该是Reserved IP addresses。 |
确实在理 |
这看上去更应该修改geoip-code让它支持多个code，或者增加单独的filter以接受指定IP段的结果 |
xishang0128
force-pushed
the
Alpha
branch
5 times, most recently
from
99b6ffa
to
44d8a14
Compare
xishang0128
force-pushed
the
Alpha
branch
4 times, most recently
from
af42ed0
to
3b472f7
Compare
xishang0128
force-pushed
the
Alpha
branch
2 times, most recently
from
c3fdcff
to
ae45564
Compare
wwqgtxx
force-pushed
the
Alpha
branch
2 times, most recently
from
c44949b
to
f3e23b1
Compare
wwqgtxx
force-pushed
the
Alpha
branch
9 times, most recently
from
ddf6cd3
to
ed1e7e3
Compare
Larvan2
force-pushed
the
Alpha
branch
2 times, most recently
from
f8b27b9
to
094537b
Compare
wwqgtxx
force-pushed
the
Alpha
branch
3 times, most recently
from
de3d214
to
3195c67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently ip.IsPrivate and netip.Addr.IsPrivate only matches a part of private IPs. This pr uses the CIDR list from geoip:private to fix it.