Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Aurora Deprecation Message is Unclear and Annoying #23078

Closed
Karkunow opened this issue Feb 20, 2024 · 13 comments · Fixed by #24534
Closed

[Bug]: Aurora Deprecation Message is Unclear and Annoying #23078

Karkunow opened this issue Feb 20, 2024 · 13 comments · Fixed by #24534
Assignees
Labels
external-contributor regression-prod-11.9.5 Regression bug that was found in production in release 11.9.5 release-11.18.0 Issue or pull request that will be included in release 11.18.0 Sev2-normal Normal severity; minor loss of service or inconvenience. team-extension-platform type-bug

Comments

@Karkunow
Copy link

Karkunow commented Feb 20, 2024

Describe the bug

I am constantly getting the Aurora deprecation message, added via this PR.

Which is misleading, as there is no planned deprecation of the Aurora network by Metamask in the foreseeable future.
It also ruins the user experience and makes people worry about using Aurora products with Metamask.

Expected behavior

I have a few suggestions about how to fix it:

  1. The message inside the popup is misleading. It says, "Aurora network will be deprecated," which simply is not true. In PR devs are just saying about the removal from Popular Network List. So, let's change it to something else, like "Aurora Chain has been removed from the Popular Network List".

  2. The second part of the message says, "Please add it as a custom network". But if I add it as custom network - I still see the message. How can I get rid of this then?

  3. It is also not clear how to add a Custom Network from that popup. In "Learn More" you just have a redirect to the aurora.dev site. I propose to change it to either https://aurora.dev/start or even better - https://support.metamask.io/hc/en-us/articles/360058992772-Add-a-network-using-Chainlist

  4. Allow the user not to see that message if he has closed it or has done the action you've asked him for.

Screenshots/Recordings

It looks like this:
Screenshot 2024-02-20 at 15 23 02

Steps to reproduce

  1. Make sure you have added Aurora Mainnet (https://aurora.dev/start) and Ethereum Mainnet networks.
  2. Switch to Ethereum Network.
  3. Switch to Aurora Network.
  4. See popup at the bottom of the screen.

Error messages or log output

No response

Version

11.9.5

Build type

None

Browser

Brave

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

  • It is a mid-severe bug for the Aurora Users and impacts the whole ecosystem
@metamaskbot metamaskbot added external-contributor regression-prod-11.9.5 Regression bug that was found in production in release 11.9.5 labels Feb 20, 2024
@Bullcoiner Bullcoiner added Sev2-normal Normal severity; minor loss of service or inconvenience. team-extension-platform labels Feb 20, 2024
@Bullcoiner
Copy link

Hi There! Thank you for reporting this, it has been assigned to the appropriate team to be looked at.

@Karkunow
Copy link
Author

@Bullcoiner looking forward to it and a person assigned directly to this issue here.

@alextechdir
Copy link

Thanks for bringing this up, we in the community already wanted to do a post about this but it wasn't clear what was meant until the end. Absolutely support this post. MM is misleading users.

@evienear
Copy link

evienear commented Mar 1, 2024

I am from a project on Aurora and our community has been extremely confused by this message. The misleading message has been a huge turn off for new users thinking something is wrong with the chain. I support this post.

@bravepooh
Copy link

Working on a project on Aurora, I've found this deprecation posted message and started to get questions from users about it. It caused some uncertainty. Hope it can be resolved

@Karkunow
Copy link
Author

Karkunow commented Mar 1, 2024

@Bullcoiner could you please push this issue on your side? Thank you!

@armanddid
Copy link

@Bullcoiner any update on this issue? This has been extremely misleading for our users. Appreciate your time in solving this!

@tuanhvdev
Copy link

@Bullcoiner I'm working on a project on Aurora chain.
Our community is very confused by this message and asking us about it. It's very misleading to our users, especially new users.
I hope it can be resolved soon. Thanks

@Karkunow
Copy link
Author

@NidhiKJha, Hello! I see you have been working on this. Could you please explain why this warning exists?
Aurora Mainnet is fully functional and working. It shouldn't be deprecated.

@Karkunow
Copy link
Author

@pedronfigueiredo, hello! I see that you've been working on Add loading message to deprecated networks (#22323) PR, could you please comment on why Aurora network was included into the Deprecation List? Thank you!

@Karkunow
Copy link
Author

@pedronfigueiredo @gauthierpetetin @NidhiKJha Hello! Can someone clarify this one? And push the issue forward to be solved? Thank you!

@bergeron bergeron self-assigned this May 2, 2024
@Karkunow
Copy link
Author

Karkunow commented May 7, 2024

@bergeron Hey! Could you please provide any updates about this one? Thank you!

@CosmicVentus
Copy link

Had this message for a while and I can assure that this is a huge turn off. Imagine staking your tokens when your metamask didn't show this bug and now you need to unstake them and you see that message. Would look super risky to remove your staked token to redeem them in a wallet with a faulty network. Please consider fixing this.

p.s. Thankfully the Aurora support team is always available to help.

bergeron added a commit that referenced this issue May 29, 2024
## **Description**

Fixes the Aurora deprecation message. It was suggesting MM no longer
supports Aurora, which is not true. It's just no longer a built-in
network due to Infura no longer supporting it.

Instead, we show a warning to users who previous added it when it was a
built-in network. And give them a 1 click migration from Infura to the
`mainnet.aurora.dev` RPC endpoint.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/24534?quickstart=1)

## **Related issues**

Fixes: #23078

## **Manual testing steps**

1. Add the Aurora network via https://chainid.network
2. Verify no deprecation warnings

The RPC migration modal is harder to test. You'd need to have added the
network on MM <= 11.6 back when the Infura RPC url was alive.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<img width="352" alt="Screenshot 2024-05-14 at 10 07 12 PM"
src="https://github.com/MetaMask/metamask-extension/assets/3500406/dbabcf56-6f0d-4bb3-95a9-2fb9c04359c4">


### **After**

Simulating a user who previously added the Infura RPC:


https://github.com/MetaMask/metamask-extension/assets/3500406/6df7591d-284f-47bc-88a3-362174bf141f

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@metamaskbot metamaskbot added the release-11.18.0 Issue or pull request that will be included in release 11.18.0 label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external-contributor regression-prod-11.9.5 Regression bug that was found in production in release 11.9.5 release-11.18.0 Issue or pull request that will be included in release 11.18.0 Sev2-normal Normal severity; minor loss of service or inconvenience. team-extension-platform type-bug
Projects
Archived in project
Status: Fixed
Development

Successfully merging a pull request may close this issue.

10 participants